Comments not working in Typo Scribbish theme 5

Posted by Tim Connor Thu, 26 Oct 2006 02:22:00 GMT

For those who may have noticed that your Typo blog won’t allow comments from IE users (is that a feature, or what?), I found the problem. 

<%= submit_tag 'Submit', :onclick => "this.disabled=true; Element.hide('preview');" %>

The “this.disable=true” disables the submit button before the form is submitted, so all that happens is the onclick. For now I am just taking that out of mine – I’ll look at a better fix later.

  1. Tim Connor 8 minutes later:

    The amazing part is that I didn’t find more about this on the intarwebs. I guess most Typo users, especially the ones using Scribbish are Mac users or something? But, I did find one email on mailing list about someone having the same problem in Safari, as well. Maybe everyone is just using Firefox, in the wbe dev world.

    This comment made with IE, as a test.

  2. www.pierocampanelli.info about 5 hours later:

    Tim, i singnalled some weeks ago the problem of IE/Safari commenting. You can try it on my blog.

    should modifying only disabled=false work?

  3. Tieg about 14 hours later:

    Interesting bug; I didn’t know it would cancel the form submission (doesn’t really make sense). An interesting related bug we found in May was that Prototype would include ‘disabled’ elements when it serializes forms, so when you do AJAX requests ‘disabled’ becomes useless. I think they finally fixed this last week in Edge Rails.

  4. Tim Connor about 15 hours later:

    Piero: Yup.

    If the author doesn’t get around to fixing it in a while, I’ll come up with a fix that submits the form, then disables the button, so we can keep that functionality. It might be as simple as calling the submit before the disables.

  5. Tim Connor about 15 hours later:

    fix-for-typo-scribbish-theme-v2-aka-disabling-a-submit-button-in-ie

Comment form

(leave url/email »)

Help with Textile (code)